Fix CI fails #319
Merged
Fix CI fails #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RmbRT
commented
Feb 8, 2022
RmbRT
commented
- Stabilise reorg resistant subscription tests, although it does not cause the inherent problem that caused the tests to fail. Fixing that would be way more involved.
- Fix bug in Adjudicator test: challenge duration (is used as timeout for the funding transactions) was selected in [0,3600), fixed to [200,3600) now, to guarantee enough time for funding.
matthiasgeihs
suggested changes
Feb 8, 2022
RmbRT
force-pushed
the
fix-ci-fails
branch
5 times, most recently
from
f8f1e27 to
140aa19
Compare
Removed an impossible error condition check and the associated log call. sync.Closer can only ever return nil or "already closed", while the removed code checked for a third error and tried to log that. I think this was caused in an attempt to please the pedantic linter. Issue #211 addresses the trouble with using the sync.Closer, as its intended usage clashes with go's idioms and conventions. In retrospect, I think I should have anticipated this problem and designed the Closer differently from the beginning. Signed-off-by: Steffen Rattay <steffen@perun.network>
Closes #320. This fixes test failures where unwanted blocks were mined quite a bit after StopMining() was called, resulting in wrong timelines. Signed-off-by: Steffen Rattay <steffen@perun.network>
The adjudicator test has a funding timeout of one challenge duration (measured in blocks), but the challenge duration was in the range [0, 3600). Now, it is generated in the range[200, 3600). Issue #239 (adding a designated funding timeout parameter) would solve this problem in a cleaner way, however, the implementation concept is still unclear. Signed-off-by: Steffen Rattay <steffen@perun.network>
matthiasgeihs
force-pushed
the
fix-ci-fails
branch
from
140aa19 to
ff7450a
Compare
matthiasgeihs
approved these changes
Feb 9, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.