-
Notifications
You must be signed in to change notification settings - Fork 18
Closed
Labels
enhancementImprovement of an existing featureImprovement of an existing featuregood first issueGood for newcomersGood for newcomers
Description
Location
[pkg/sync] Closer.Close() error function.
Problem
The Close function can only return one error; alreadyClosedError. In case it was not already closed, it just returns nil.
Proposal
Since it only returns one error type, we could also use a success bool here for brevity.
This would also make the error handling shorter since we often log errors when handling them.
Metadata
Metadata
Assignees
Labels
enhancementImprovement of an existing featureImprovement of an existing featuregood first issueGood for newcomersGood for newcomers