Skip to content

[pkg/sync] Closer.Close() returns error #211

@ggwpez

Description

@ggwpez

Location

[pkg/sync] Closer.Close() error function.

Problem

The Close function can only return one error; alreadyClosedError. In case it was not already closed, it just returns nil.

Proposal

Since it only returns one error type, we could also use a success bool here for brevity.
This would also make the error handling shorter since we often log errors when handling them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions