Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core deploy apply admin proxy ownership fixes #4767

Merged
merged 36 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
c675dbb
feat(sdk): updated the RouterConfigSchema to have an optional proxyAd…
xeno097 Oct 21, 2024
b978591
refactor(sdk): defined the DeployedOwnableConfig and DeployedOwnableS…
xeno097 Oct 21, 2024
747b008
feat(sdk): updated the EvmWarpReader to add a fetchAdminProxyData met…
xeno097 Oct 21, 2024
85843da
feat(sdk): added the updateProxyAdminOwnershipTxs method to the EvmE…
xeno097 Oct 21, 2024
a55dc01
feat(cli): implemented the setExistingProxyAdmin to promt users to us…
xeno097 Oct 21, 2024
e8e9fc0
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
xeno097 Oct 21, 2024
b192810
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
xeno097 Oct 22, 2024
50d2047
docs(changeset): Add optional proxy admin reuse in warp route deploym…
xeno097 Oct 22, 2024
552bbb5
chore: paul pr review suggestion
xeno097 Oct 22, 2024
8082d17
fix(sdk): fixed methdo cann for fetchProxyAdminConfig
xeno097 Oct 22, 2024
cf5f0aa
feat(cli): added proxy admin and ica router ownership configurability…
xeno097 Oct 23, 2024
9440e50
feat(sdk): updated the EvmCoreModule.deploy method to check if the co…
xeno097 Oct 23, 2024
a8f4683
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
xeno097 Oct 23, 2024
62c2067
chore: lee pr review changes + e2e test fix for warp route apply
xeno097 Oct 24, 2024
a03e1d0
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
xeno097 Oct 24, 2024
c59ad8b
fix(sdk): fixed deriveTokenMetadata return value to exlcude fields no…
xeno097 Oct 24, 2024
7fc834d
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
xeno097 Oct 24, 2024
7c5d84d
Merge branch 'xeno/warp-deploy-apply-ownership-fixes' of github.com:h…
xeno097 Oct 24, 2024
e396abc
feat(sdk): updated the EvmCoreReader to fetch the admin proxy data fo…
xeno097 Oct 24, 2024
cca3416
refactor(sdk): implemented the proxyAdminOwnershipUpdateTxs to dedup …
xeno097 Oct 25, 2024
1c8c682
test(cli): implemented testing utils for core commands testing
xeno097 Oct 25, 2024
3623d06
refactor(sdk,infra): remvoed duplicated impls of randomAddress
xeno097 Oct 25, 2024
86178c9
test(cli): updated the test e2e script to also run a anvil 1 chain on…
xeno097 Oct 25, 2024
cdadfe4
test(cli): added e2e tests for the hyperlane core commands
xeno097 Oct 25, 2024
16f9b46
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
xeno097 Oct 25, 2024
7c48117
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
xeno097 Oct 25, 2024
300af54
Merge branch 'xeno/warp-deploy-apply-ownership-fixes' of github.com:h…
xeno097 Oct 25, 2024
46c1dfb
refactor(cli): removed ica router proxy admin setting from core init …
xeno097 Oct 25, 2024
d58f6a7
docs(changeset): Add support for updating the mailbox proxy admin owner
xeno097 Oct 25, 2024
4a7798d
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
xeno097 Nov 1, 2024
1e7c304
chore: fix main merge dup code
xeno097 Nov 1, 2024
872cb39
chore: lee pr changes
xeno097 Nov 1, 2024
f204163
test: maybe fix e2e test issues
xeno097 Nov 2, 2024
30cd02e
feat(sdk,cli): added logic to update proxy admin contract + test
xeno097 Nov 4, 2024
7798c00
fix: maybe fix e2e test part 3
xeno097 Nov 4, 2024
52936e1
Merge branch 'main' of github.com:hyperlane-xyz/hyperlane-monorepo in…
xeno097 Nov 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: maybe fix e2e test issues
  • Loading branch information
xeno097 committed Nov 2, 2024
commit f204163074faeab635b0401097f5e26370587d28
6 changes: 1 addition & 5 deletions typescript/cli/scripts/run-e2e-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,16 @@
function cleanup() {
set +e
pkill -f anvil
rm -rf /tmp/anvil1
rm -rf /tmp/anvil2
rm -rf /tmp/anvil3
rm -f ./test-configs/anvil/chains/anvil1/addresses.yaml
rm -f ./test-configs/anvil/chains/anvil2/addresses.yaml
rm -f ./test-configs/anvil/chains/anvil3/addresses.yaml
set -e
}

cleanup

echo "Starting anvil1, anvil2 and anvil3 chain for E2E tests"
# Anvil1 should be used only for core commands e2e testing to avoid interfierence with other e2e tests
anvil --chain-id 31337 -p 8545 --state /tmp/anvil1/state --gas-price 1 > /dev/null &
echo "Starting anvil2 and anvil3 chain for E2E tests"
anvil --chain-id 31338 -p 8555 --state /tmp/anvil2/state --gas-price 1 > /dev/null &
anvil --chain-id 31347 -p 8600 --state /tmp/anvil3/state --gas-price 1 > /dev/null &

Expand Down
11 changes: 8 additions & 3 deletions typescript/cli/src/tests/warp-deploy.e2e-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const WARP_CORE_CONFIG_PATH_2_3 = `${REGISTRY_PATH}/deployments/warp_routes/VAUL
const TEST_TIMEOUT = 60_000; // Long timeout since these tests can take a while
describe('WarpDeploy e2e tests', async function () {
let chain2Addresses: ChainAddresses = {};
let chain3Addresses: ChainAddresses = {};
let token: any;
let vault: any;

Expand All @@ -46,7 +47,11 @@ describe('WarpDeploy e2e tests', async function () {
ANVIL_KEY,
);

await deployOrUseExistingCore(CHAIN_NAME_3, CORE_CONFIG_PATH, ANVIL_KEY);
chain3Addresses = await deployOrUseExistingCore(
CHAIN_NAME_3,
CORE_CONFIG_PATH,
ANVIL_KEY,
);

token = await deployToken(ANVIL_KEY, CHAIN_NAME_2);
vault = await deploy4626Vault(ANVIL_KEY, CHAIN_NAME_2, token.address);
Expand Down Expand Up @@ -81,8 +86,8 @@ describe('WarpDeploy e2e tests', async function () {
},
[CHAIN_NAME_3]: {
type: TokenType.syntheticRebase,
mailbox: chain2Addresses.mailbox,
owner: chain2Addresses.mailbox,
mailbox: chain3Addresses.mailbox,
owner: chain3Addresses.mailbox,
collateralChainName: CHAIN_NAME_2,
},
};
Expand Down
Loading