feat: core deploy apply admin proxy ownership fixes #4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min field to allow deploy overrides and checks
…hod to retrive proxy admin data
…e an already existing proxy admi ncontract for deployments
…to xeno/warp-deploy-apply-ownership-fixes
…to xeno/warp-deploy-apply-ownership-fixes
…ents and admin proxy ownership transfer in warp apply
Co-authored-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
… to core init command
…nfig defines owners fro the mailbox proxy admin adn ica router and use those values intead of the signer
…to xeno/warp-deploy-apply-ownership-fixes
…to xeno/warp-deploy-apply-ownership-fixes
…t defined on the type
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
…r the mailbox contract
…admin proxy ownership code
…ly for core command testing
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…to xeno/warp-deploy-apply-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
xeno097
requested review from
Mo-Hussain,
jmrossy,
yorhodes and
ltyu
as code owners
🦋 Changeset detectedLatest commit: 52936e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Base automatically changed from
xeno/warp-deploy-apply-ownership-fixes
to
main
November 1, 2024 16:04
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4767 +/- ##
=======================================
Coverage 74.58% 74.58%
=======================================
Files 103 103
Lines 1515 1515
Branches 195 195
=======================================
Hits 1130 1130
Misses 364 364
Partials 21 21
|
ltyu
approved these changes
Nov 1, 2024
ltyu
reviewed
Nov 1, 2024
paulbalaji
reviewed
Nov 4, 2024
paulbalaji
reviewed
Nov 5, 2024
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
xeno097
deleted the
xeno/core-deploy-apply-admin-proxy-ownership-fixes
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
### Description This PR adds the required logic to enroll/unenroll ICAs between them when running `core apply` ### Drive-by changes - Implements the `EvmIcaReader` - Updates the `EvmCoreModule` to read the current chain ICA config - Adds tests for the `EvmIcaRouterReader` ### Related issues - Fixes #4819 ### Backward compatibility - Yes ### Testing - Manual - E2E ### Note - merge #4767 first --------- Co-authored-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
### Description This PR updates the `hyperlane core init`, `hyperlane core deploy` and `hyperlane core apply` commands to allow a user to change ownership of the mailbox ProxyAdmin contract by setting a value in the config. ### Drive-by changes - deduped `randomAddress` test util implementations across the `sdk`, 'infra' and `cli` package - added `anvil1` to the `run-e2e-test.sh` script to test `hyperlane core` commands in isolation - implemented the `proxyAdminOwnershipUpdateTxs` to deduplicate proxy admin ownership tx data generation ### Related issues - Fixes hyperlane-xyz#4728 ### Backward compatibility - Yes ### Testing - Manual - e2e ### NOTE: - Merge hyperlane-xyz#4726 first --------- Co-authored-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
### Description This PR adds the required logic to enroll/unenroll ICAs between them when running `core apply` ### Drive-by changes - Implements the `EvmIcaReader` - Updates the `EvmCoreModule` to read the current chain ICA config - Adds tests for the `EvmIcaRouterReader` ### Related issues - Fixes hyperlane-xyz#4819 ### Backward compatibility - Yes ### Testing - Manual - E2E ### Note - merge hyperlane-xyz#4767 first --------- Co-authored-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
### Description This PR updates the `hyperlane core init`, `hyperlane core deploy` and `hyperlane core apply` commands to allow a user to change ownership of the mailbox ProxyAdmin contract by setting a value in the config. ### Drive-by changes - deduped `randomAddress` test util implementations across the `sdk`, 'infra' and `cli` package - added `anvil1` to the `run-e2e-test.sh` script to test `hyperlane core` commands in isolation - implemented the `proxyAdminOwnershipUpdateTxs` to deduplicate proxy admin ownership tx data generation ### Related issues - Fixes hyperlane-xyz#4728 ### Backward compatibility - Yes ### Testing - Manual - e2e ### NOTE: - Merge hyperlane-xyz#4726 first --------- Co-authored-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Jan 11, 2025
### Description This PR adds the required logic to enroll/unenroll ICAs between them when running `core apply` ### Drive-by changes - Implements the `EvmIcaReader` - Updates the `EvmCoreModule` to read the current chain ICA config - Adds tests for the `EvmIcaRouterReader` ### Related issues - Fixes hyperlane-xyz#4819 ### Backward compatibility - Yes ### Testing - Manual - E2E ### Note - merge hyperlane-xyz#4767 first --------- Co-authored-by: Paul Balaji <10051819+paulbalaji@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
hyperlane core init,hyperlane core deployandhyperlane core applycommands to allow a user to change ownership of the mailbox ProxyAdmin contract by setting a value in the config.Drive-by changes
randomAddresstest util implementations across thesdk, 'infra' andclipackageanvil1to therun-e2e-test.shscript to testhyperlane corecommands in isolationproxyAdminOwnershipUpdateTxsto deduplicate proxy admin ownership tx data generationRelated issues
Backward compatibility
Testing
NOTE: