Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insertion errors for txn and block #2629

Merged
merged 8 commits into from
Aug 11, 2023

Conversation

mattiekat
Copy link
Contributor

@mattiekat mattiekat commented Aug 9, 2023

Description

This resolves the insertion conflict that is being caused by #2246 that introduced multiple concurrent tasks to scrape. This does not address the underlying concurrency issue I discovered, however. Please review the issue comments for more details.

Drive-by changes

  • Cleans up logs a bit (This was useful during testing and I think is useful globally)
  • Removed an unused file

Related issues

Fixes hyperlane-xyz/issues#493
Relates to #2631

Backward compatibility

Yes

Testing

Manual

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c53c1f7) 65.39% compared to head (449639e) 65.39%.
Report is 1 commits behind head on main.

❗ Current head 449639e differs from pull request most recent head 88326c2. Consider uploading reports for the commit 88326c2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2629   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files          89       89           
  Lines        1358     1358           
  Branches      182      182           
=======================================
  Hits          888      888           
  Misses        463      463           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattiekat mattiekat marked this pull request as ready for review August 9, 2023 15:05
@mattiekat mattiekat requested review from tkporter and asaj as code owners August 9, 2023 15:05
@mattiekat mattiekat enabled auto-merge (squash) August 11, 2023 16:28
@mattiekat mattiekat merged commit 041cf92 into main Aug 11, 2023
@mattiekat mattiekat deleted the mattie/scraper/block-hash-key-duplicate branch August 11, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants