Refactor agent event indexing #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaj
changed the title
asaj
commented
May 17, 2023
tkporter
approved these changes
May 18, 2023
…norepo into asaj/indexing
…norepo into asaj/indexing
tkporter
added a commit
that referenced
this pull request
May 25, 2023
…mAccounts based indexing (#2273) ### Description * Pulls main, mostly to include #2246 * Fixes #2205 * Moves to a getProgramAccounts based indexing ### Drive-by changes n/a ### Related issues - Fixes #2205 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests --------- Co-authored-by: Nam Chu Hoai <nambrot@googlemail.com> Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz> Co-authored-by: J M Rossy <jm.rossy@gmail.com> Co-authored-by: Mattie Conover <git@mconover.dev> Co-authored-by: Asa Oines <asaoines@gmail.com> Co-authored-by: Sergei Patrikeev <serejke.best@gmail.com>
This was referenced Aug 9, 2023
mattiekat
added a commit
that referenced
this pull request
Aug 11, 2023
### Description This resolves the insertion conflict that is being caused by #2246 that introduced multiple concurrent tasks to scrape. This does not address the underlying concurrency issue I discovered, however. Please review the issue comments for more details. ### Drive-by changes - Cleans up logs a bit (This was useful during testing and I think is useful globally) - Removed an unused file ### Related issues Fixes hyperlane-xyz/issues#493 ### Backward compatibility Yes ### Testing Manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors event indexing in the agents, allowing similar logic to be shared across multiple event types (i.e. messages, deliveries, gas payments) and database types (i.e. the Relayer rocks DB and Scraper SQL DB).
Furthermore, it adds new syncing modes by way of
MessageSyncCursorsthat take advantage of the monotonically increasing dispatched message nonce to sync more intelligently.Drive-by changes
Opportunities for improvement
Related issues
Backward compatibility
Are these changes backward compatible?
Yes
Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?
None
Testing
What kind of testing have these changes undergone?
E2E tests