Add a typescript rule so that array<T>[i] is T | undefined#181
Merged
Conversation
Because i could be out of bounds (or even: not an integer). This rule is sometimes really annoying (some call it pedantic), but I think it can help find bugs. I'm enabling it as a distinct PR, before a bigger PR where I upgrade hightable, and need to add code to sort the rows along multiple columns, where I prefer to have this rule enabled, as in hightable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because i could be out of bounds (or even: not an integer).
This rule is sometimes really annoying (some call it pedantic), but I think it can help find bugs.
I'm enabling it as a distinct PR, before a bigger PR (#180) where I upgrade hightable, and need to add code to sort the rows along multiple columns, where I prefer to have this rule enabled, as in hightable.