Conversation
52611e5 to
a4d0998
Compare
699b041 to
8ee869c
Compare
This was referenced Mar 26, 2025
Contributor
Author
|
Also, note that for parquet, as we're interested in getting the ranks of a sorted column, not the values, we could improve the performance by using the row group metadata (min/max). But I guess it's more something to be done in hyparquet. |
…orderBy in particular)
27c04a1 to
7ddf178
Compare
platypii
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reference, here is the CHANGELOG for hightable 0.13.0: https://github.com/hyparam/hightable/blob/master/CHANGELOG.md#0130---2025-03-21
This PR was not trivial because it required handling multi-column sorting for parquet.
I implemented it with the following details:
getParquetColumn, to fetch the values of a given column without transposing to rows (usingparquetReadandonChunk)orderBycriteria by getting the ranks for each column and sorting the rows using the following column for each tie.