Skip to content

Commit

Permalink
tools/gn: delete generate_test_gn_data tool
Browse files Browse the repository at this point in the history
In the beginning, when gn was released, it was used to make performance
tests, as we didn't have many BUILD.gn files.

Now that we have hundreds of them in tree, this is not necessary, as the
performance can be tested with real data.

BUG=94925, 372642
R=brettw@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1534823002

Cr-Commit-Position: refs/heads/master@{#368492}
  • Loading branch information
tfarina authored and Commit bot committed Jan 9, 2016
1 parent 8e58488 commit 8e5f41b
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 150 deletions.
1 change: 0 additions & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ group("both_gn_and_gyp") {
"//third_party/codesighs",
"//third_party/pdfium/samples:pdfium_test",
"//tools/gn",
"//tools/gn:generate_test_gn_data",
"//tools/gn:gn_unittests",
"//tools/perf/clear_system_cache",
"//ui/accessibility:accessibility_unittests",
Expand Down
1 change: 0 additions & 1 deletion build/gn_migration.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,6 @@
'../third_party/codesighs/codesighs.gyp:maptsvdifftool',
'../third_party/pdfium/samples/samples.gyp:pdfium_diff',
'../third_party/pdfium/samples/samples.gyp:pdfium_test',
'../tools/gn/gn.gyp:generate_test_gn_data',
'../tools/gn/gn.gyp:gn',
'../tools/gn/gn.gyp:gn_unittests',
'../tools/perf/clear_system_cache/clear_system_cache.gyp:clear_system_cache',
Expand Down
10 changes: 0 additions & 10 deletions tools/gn/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -312,13 +312,3 @@ test("gn_unittests") {
"//testing/gtest",
]
}

executable("generate_test_gn_data") {
sources = [
"generate_test_gn_data.cc",
]
deps = [
"//base",
"//build/config/sanitizers:deps",
]
}
2 changes: 1 addition & 1 deletion tools/gn/bootstrap/bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def write_ninja(path, options):
continue
if name.endswith('_unittest.cc'):
continue
if name in ['generate_test_gn_data.cc', 'run_all_unittests.cc']:
if name == 'run_all_unittests.cc':
continue
full_path = os.path.join(GN_ROOT, name)
static_libraries['gn']['sources'].append(
Expand Down
127 changes: 0 additions & 127 deletions tools/gn/generate_test_gn_data.cc

This file was deleted.

10 changes: 0 additions & 10 deletions tools/gn/gn.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -267,16 +267,6 @@
'../../testing/gtest.gyp:gtest',
],
},
{
'target_name': 'generate_test_gn_data',
'type': 'executable',
'sources': [
'generate_test_gn_data.cc',
],
'dependencies': [
'../../base/base.gyp:base',
],
}
],
'conditions': [
['test_isolation_mode != "noop"', {
Expand Down

0 comments on commit 8e5f41b

Please sign in to comment.