Skip to content

Commit

Permalink
chrome: fix gn check errors for "test_support" target under app direc…
Browse files Browse the repository at this point in the history
…tory

Checked on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/app/*

BUG=367595,376000
R=thestig@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/1572673002

Cr-Commit-Position: refs/heads/master@{#368491}
  • Loading branch information
tfarina authored and Commit bot committed Jan 9, 2016
1 parent c9c3a68 commit 8e58488
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 1 deletion.
1 change: 1 addition & 0 deletions .gn
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ check_targets = [
"//cc/*",

#"//chrome/*", # Epic number of errors.
"//chrome/app/*",
"//chrome/common/*",
"//chrome/installer/*",
"//chrome/third_party/mozilla_security_manager/*",
Expand Down
26 changes: 25 additions & 1 deletion chrome/app/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -322,21 +322,45 @@ source_set("test_support") {
deps = [
"//base",
"//chrome/browser",
"//chrome/browser/policy:path_parser",
"//chrome/child",
"//chrome/common",
"//chrome/plugin",
"//chrome/renderer",
"//chrome/utility",
"//components/crash/content/app",
"//components/crash/content/app:lib",
"//components/startup_metric_utils/browser:lib",
"//content/public/app:both",
"//content/public/common",
"//ui/base",
]

if (is_mac) {
sources += [ "chrome_main_mac.mm" ]

deps += [ "//chrome:main_dll" ]
}

if (is_win) {
deps += [
"//chrome:chrome_initial",
"//sandbox/win:sandbox",
]
}

if (is_chromeos) {
deps += [ "//chrome/browser/chromeos" ]
}

if (enable_pdf) {
deps += [ "//pdf" ]
}

if (enable_plugins && enable_nacl) {
deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ]
deps += [
"//components/nacl/browser",
"//components/nacl/renderer/plugin:nacl_trusted_plugin",
]
}
}

0 comments on commit 8e58488

Please sign in to comment.