Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Nov 5, 2024

PR Description: Implement Changes to Serve Command

This pull request addresses issue #1994 by updating the serve command to not save pages by default. This change aims to enhance the developer experience by making the behavior of the serve command less unexpected.

Motivation for the Change

  • Unexpected Behavior: The current implementation of the serve command saves pages by default, which can be surprising for developers who do not anticipate this action.
  • Improved Development Workflow: By not saving pages by default, the development workflow becomes more intuitive, allowing developers to preview changes without automatically persisting them.

Key Changes

  • Update the serve command to disable automatic saving of pages by default.
  • The option for users to enable saving if desired is still available.

This PR fixes #1994

@emmadesilva emmadesilva force-pushed the no-longer-save-realtime-compiler-pages-by-default branch from fe851c5 to c58c7dc Compare November 5, 2024 14:02
@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4622237) to head (c58c7dc).
Report is 2 commits behind head on 2.x-dev.

Additional details and impacted files
@@             Coverage Diff             @@
##             2.x-dev     #1995   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1884      1884           
===========================================
  Files            193       193           
  Lines           5028      5028           
===========================================
  Hits            5028      5028           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva marked this pull request as ready for review November 5, 2024 14:04
@emmadesilva emmadesilva merged commit c4cbe6e into 2.x-dev Nov 5, 2024
7 checks passed
@emmadesilva emmadesilva deleted the no-longer-save-realtime-compiler-pages-by-default branch November 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants