Skip to content

[2.x] Update default configuration to no longer save previewed pages #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[2.x] Update default configuration to no longer save previewed pages #1995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ This serves two purposes:
- Minor: The `processing_time_ms` attribute in the `sitemap.xml` file has now been removed in https://github.com/hydephp/develop/pull/1744
- Minor: Updated the `Hyde::url()` helper throw a `BadMethodCallException` instead `BaseUrlNotSetException` when no site URL is set and no path was provided to the method in https://github.com/hydephp/develop/pull/1760 and https://github.com/hydephp/develop/pull/1890
- Minor: Updated the blog post layout and post feed component to use the `BlogPosting` Schema.org type instead of `Article` in https://github.com/hydephp/develop/pull/1887
- Updated default configuration to no longer save previewed pages in https://github.com/hydephp/develop/pull/1995
- Added more rich markup data to blog post components in https://github.com/hydephp/develop/pull/1888 (Note that this inevitably changes the HTML output of the blog post components, and that any customized templates will need to be republished to reflect these changes)
- Overhauled the blog post author feature in https://github.com/hydephp/develop/pull/1782
- Improved the sitemap data generation to be smarter and more dynamic in https://github.com/hydephp/develop/pull/1744
Expand Down
2 changes: 1 addition & 1 deletion config/hyde.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@
'host' => env('SERVER_HOST', 'localhost'),

// Should preview pages be saved to the output directory?
'save_preview' => true,
'save_preview' => false,

// Should the live edit feature be enabled?
'live_edit' => env('SERVER_LIVE_EDIT', true),
Expand Down
2 changes: 1 addition & 1 deletion docs/extensions/realtime-compiler.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ The server can be configured in the `config/hyde.php` file to change the port, h
'server' => [
'port' => env('SERVER_PORT', 8080),
'host' => env('SERVER_HOST', 'localhost'),
'save_preview' => true,
'save_preview' => false,
],
```

Expand Down
2 changes: 1 addition & 1 deletion packages/framework/config/hyde.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@
'host' => env('SERVER_HOST', 'localhost'),

// Should preview pages be saved to the output directory?
'save_preview' => true,
'save_preview' => false,

// Should the live edit feature be enabled?
'live_edit' => env('SERVER_LIVE_EDIT', true),
Expand Down
12 changes: 0 additions & 12 deletions packages/realtime-compiler/tests/RealtimeCompilerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,6 @@ public function testHandlesRoutesIndexPage()
$this->assertEquals(200, $response->statusCode);
$this->assertEquals('OK', $response->statusMessage);
$this->assertStringContainsString('<title>Welcome to HydePHP!</title>', $response->body);

$this->assertFileExists(hyde()->path('_site/index.html'));
$this->assertEquals($response->body, Filesystem::get('_site/index.html'));

Filesystem::unlink('_site/index.html');
}

public function testHandlesRoutesCustomPages()
Expand All @@ -71,13 +66,10 @@ public function testHandlesRoutesCustomPages()
$this->assertStringContainsString('<h1>Hello World!</h1>', $response->body);

Filesystem::unlink('_pages/foo.md');
Filesystem::unlink('_site/foo.html');
}

public function testHandlesRoutesPagesWithHtmlExtension()
{
$this->mockRoute('foo.html');

Filesystem::put('_pages/foo.md', '# Hello World!');

$kernel = new HttpKernel();
Expand All @@ -89,7 +81,6 @@ public function testHandlesRoutesPagesWithHtmlExtension()
$this->assertStringContainsString('<h1>Hello World!</h1>', $response->body);

Filesystem::unlink('_pages/foo.md');
Filesystem::unlink('_site/foo.html');
}

public function testHandlesRoutesStaticAssets()
Expand Down Expand Up @@ -144,7 +135,6 @@ public function testTrailingSlashesAreNormalizedFromRoute()
$this->assertStringContainsString('<h1>Hello World!</h1>', $response->body);

Filesystem::unlink('_pages/foo.md');
Filesystem::unlink('_site/foo.html');
}

public function testDocsUriPathIsReroutedToDocsIndex()
Expand All @@ -162,7 +152,6 @@ public function testDocsUriPathIsReroutedToDocsIndex()
$this->assertStringContainsString('HydePHP Docs', $response->body);

Filesystem::unlink('_docs/index.md');
Filesystem::unlink('_site/docs/index.html');
}

public function testDocsSearchRendersSearchPage()
Expand All @@ -179,7 +168,6 @@ public function testDocsSearchRendersSearchPage()
$this->assertStringContainsString('Search the documentation site', $response->body);

Filesystem::unlink('_docs/index.md');
Filesystem::unlink('_site/docs/search.html');
}

public function testPingRouteReturnsPingResponse()
Expand Down