Skip to content

Improve the realtime compiler dashboard #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Improve the realtime compiler dashboard #1866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7ec80f
Add ternary check to not show source path for virtual pages
emmadesilva Jul 17, 2024
5e93987
Improve dashboard table item formatting
emmadesilva Jul 17, 2024
2e1997a
Disable dashboard button to edit in-memory pages
emmadesilva Jul 17, 2024
d54748d
Stylize formatting of dynamic source file label
emmadesilva Jul 17, 2024
8c86f54
Remove identifier row from dashboard table
emmadesilva Jul 17, 2024
ff85aee
Update RELEASE_NOTES.md
emmadesilva Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ This serves two purposes:
- Improved the accessibility of the heading permalinks feature in https://github.com/hydephp/develop/pull/1803
- Updated to HydeFront v3.4 in https://github.com/hydephp/develop/pull/1803
- Realtime Compiler: Virtual routes are now managed through the service container in https://github.com/hydephp/develop/pull/1858
- Realtime Compiler: Improved the dashboard layout in https://github.com/hydephp/develop/pull/1866

### Deprecated
- The `PostAuthor::getName()` method is now deprecated and will be removed in v2. (use `$author->name` instead) in https://github.com/hydephp/develop/pull/1794
Expand All @@ -31,6 +32,7 @@ This serves two purposes:
- Fixed heading permalinks button text showing in Google Search previews https://github.com/hydephp/develop/issues/1801 in https://github.com/hydephp/develop/pull/1803
- Realtime Compiler: Updated the exception handler to match HTTP exception codes when sending error responses in https://github.com/hydephp/develop/pull/1853
- Realtime Compiler: Improved routing for nested index pages in https://github.com/hydephp/develop/pull/1852
- Realtime Compiler: Improved the dashboard https://github.com/hydephp/develop/pull/1866 fixing https://github.com/hydephp/realtime-compiler/issues/22 and https://github.com/hydephp/realtime-compiler/issues/29

### Security
- in case of vulnerabilities.
17 changes: 11 additions & 6 deletions packages/realtime-compiler/resources/dashboard.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
<div class="table-responsive">
<table class="table table-bordered">
<tr>
@foreach(['Page Type', 'Route Key', 'Source File', 'Output File', 'Identifier'] as $header)
@foreach(['Page Type', 'Route Key', 'Source File', 'Output File'] as $header)
<th>{{ $header }}</th>
@endforeach
<th class="text-end">Actions</th>
Expand All @@ -245,22 +245,27 @@
{{ $route->getRouteKey() }}
</td>
<td>
{{ $route->getSourcePath() }}
@if($route->getPage() instanceof \Hyde\Pages\InMemoryPage)
<i class="text-muted" title="This page is generated dynamically and does not have a source file.">{{ '<none>' }}</i>
@else
{{ $route->getSourcePath() }}
@endif
</td>
<td>
{{ $route->getOutputPath() }}
</td>
<td>
{{ $route->getPageIdentifier() }}
</td>
<td class="text-end">
<div class="d-flex justify-content-end">
@if($dashboard->isInteractive())
<form class="buttonActionForm" action="" method="POST">
<input type="hidden" name="_token" value="{{ $csrfToken }}">
<input type="hidden" name="action" value="openPageInEditor">
<input type="hidden" name="routeKey" value="{{ $route->getRouteKey() }}">
<button type="submit" class="btn btn-outline-primary btn-sm me-2" title="Open in system default application">Edit</button>
@if($route->getPage() instanceof \Hyde\Pages\InMemoryPage)
<button type="submit" class="btn btn-outline-secondary btn-sm me-2" title="Cannot edit in-memory pages" style="pointer-events: auto; cursor: unset" disabled>Edit</button>
@else
<button type="submit" class="btn btn-outline-primary btn-sm me-2" title="Open in system default application">Edit</button>
@endif
</form>
@endif
<a href="{{ $route->getLink() }}" class="btn btn-outline-primary btn-sm" title="Open this page preview in browser">View</a>
Expand Down