-
-
Notifications
You must be signed in to change notification settings - Fork 12
[2.x] Create new navigation destination class to replace external routes #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
emmadesilva
merged 33 commits into
improved-navigation-internals
from
create-new-navigation-destination-class
Mar 24, 2024
Merged
[2.x] Create new navigation destination class to replace external routes #1636
emmadesilva
merged 33 commits into
improved-navigation-internals
from
create-new-navigation-destination-class
Mar 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-destination-class
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1636 +/- ##
===================================================================
+ Coverage 99.85% 99.87% +0.02%
- Complexity 1783 1787 +4
===================================================================
Files 185 185
Lines 4812 4816 +4
===================================================================
+ Hits 4805 4810 +5
+ Misses 7 6 -1 ☔ View full report in Codecov by Sentry. |
e677fdd to
faea07b
Compare
be2a58b to
6a64d13
Compare
We need the kernel and config so we can check if the routes exist
69ff9bd to
218590d
Compare
This reverts commit eb81668.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #1568, instead of #1635