-
-
Notifications
You must be signed in to change notification settings - Fork 13
[2.x] Experiment with splitting out the route model #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1635 +/- ##
===================================================================
- Coverage 99.85% 99.73% -0.13%
- Complexity 1783 1786 +3
===================================================================
Files 185 186 +1
Lines 4812 4818 +6
===================================================================
Hits 4805 4805
- Misses 7 13 +6 ☔ View full report in Codecov by Sentry. |
|
Yeah, no. This is definitely not solving the right problem. |
Targets #1568 and experiments with extracting a PageRoute model.
This may add too much complexity, and not solve the right problem (as the issue is with ExternalRoutes being hacky, but since they are new and just used in navigation it may be better to improve that instead), but I wanted to visualize what this could look like before making a decision.