Skip to content

Conversation

@emmadesilva
Copy link
Member

Targets #1568 and experiments with extracting a PageRoute model.

This may add too much complexity, and not solve the right problem (as the issue is with ExternalRoutes being hacky, but since they are new and just used in navigation it may be better to improve that instead), but I wanted to visualize what this could look like before making a decision.

@emmadesilva emmadesilva changed the title [2.x] Experiment with split out the route model [2.x] Experiment with splitting out the route model Mar 24, 2024
@codecov
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (a2baea5) to head (510649a).

❗ Current head 510649a differs from pull request most recent head d5fa496. Consider uploading reports for the commit d5fa496 to get more accurate results

Additional details and impacted files
@@                         Coverage Diff                         @@
##             improved-navigation-internals    #1635      +/-   ##
===================================================================
- Coverage                            99.85%   99.73%   -0.13%     
- Complexity                            1783     1786       +3     
===================================================================
  Files                                  185      186       +1     
  Lines                                 4812     4818       +6     
===================================================================
  Hits                                  4805     4805              
- Misses                                   7       13       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva
Copy link
Member Author

Yeah, no. This is definitely not solving the right problem.

@emmadesilva emmadesilva deleted the split-out-route-model branch March 24, 2024 10:20
emmadesilva added a commit that referenced this pull request Mar 24, 2024
emmadesilva added a commit that referenced this pull request Mar 24, 2024
@emmadesilva emmadesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants