added tf_prefix param and namespace support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
| @@ -12,7 +12,7 @@ namespace rosbot_hardware_interfaces | |||
| { | |||
| CallbackReturn RosbotSystem::on_init(const hardware_interface::HardwareInfo& hardware_info) | |||
| { | |||
| RCLCPP_INFO(rclcpp::get_logger("RosbotSystem"), "Initializing"); | |||
| RCLCPP_INFO(rclcpp::get_logger("rosbot_system"), "Initializing"); | |||
There was a problem hiding this comment.
Why not like this?
Suggested change
| RCLCPP_INFO(rclcpp::get_logger("rosbot_system"), "Initializing"); | |
| RCLCPP_INFO(node_->get_logger(), "Initializing"); |
There was a problem hiding this comment.
I suggest also change node name from "rosbot_system_node" to simply "rosbot_system"
There was a problem hiding this comment.
The node_ is created at the end of the on_init function. This would cause segmentation fault.
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.