Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made runProcess errors more descriptive #51

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Made runProcess errors more descriptive #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cd964b
Made runProcess errors more descriptive
s-m-martin Jul 3, 2023
60aa3e4
Added colorful error output
s-m-martin Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions Powershell/InstallHuntress.powershellv2.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,12 +560,25 @@ function getAgentPath {
# attempt to run a process and log the results AB
function runProcess ($process, $flags, $name){
try {
Start-Process $process $flags | Wait-Process -Timeout $timeout -ErrorAction Stop
$proc = Start-Process $process $flags -PassThru
Wait-Process -Timeout $timeout -ErrorAction Stop -InputObject $proc
LogMessage "$($name) finished"
} catch {
Stop-Process $process -Force
$err = "ERROR: $($name) failed to complete in $timeout seconds."
Write-Output $err -ForegroundColor white -BackgroundColor red
$e = $_.Exception
$msg = $e.Message
# Gather all the exceptions and their children
while ($e.InnerException) {
$e = $e.InnerException
$msg += "`n" + $e.Message
}

# Try to kill hung processs
if ($proc) {
Stop-Process $proc.id -Force -ErrorAction SilentlyContinue
}

$err = "ERROR: $($name) running as '$($process) $($flags)' failed to complete in $timeout seconds, full error message: '$($msg).'"
Write-Host $err -ForegroundColor white -BackgroundColor red
LogMessage $err
copyLogAndExit
}
Expand All @@ -588,13 +601,13 @@ function uninstallHuntress {
if (Test-Path $agentPath) {
# run uninstaller.exe, if not found run the Agent's built in uninstaller and the Updater's built in uninstaller
if (Test-Path $uninstallerPath) {
runProcess "$($uninstallerPath)" "/S" "Uninstall.exe" -wait
runProcess "$($uninstallerPath)" "/S" "Uninstall.exe"
$wasUninstallerRun = $true
} elseif (Test-Path $exeAgentPath) {
runProcess "$($exeAgentPath)" "/S" "Huntress Agent uninstaller" -wait
runProcess "$($exeAgentPath)" "/S" "Huntress Agent uninstaller"
$wasUninstallerRun = $true
} elseif (Test-Path $updaterPath) {
runProcess "$($updaterPath)" "/S" "Updater uninstaller" -wait
runProcess "$($updaterPath)" "/S" "Updater uninstaller"
$wasUninstallerRun = $true
} else {
LogMessage "Agent path found but no uninstallers found. Attempting to manually uninstall"
Expand Down