Made runProcess errors more descriptive #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes made
Run process was always printing a timeout error, even if the cause wasn't a timeout. That's been fixed so that more detailed errors are returned.
We're also separately grabbing the process object now in order to be able to properly kill it - this ensures we always kill the right process, not a process that just luckily has the same name. This removes the edge case that multiple instances of the install huntress script are running on the same host at the same time.
The new message looks as follows depending on the error:
More help is needed to update the other RMM scripts using this powershell