generated from fastai/nbdev_template
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🗃️ Use specified data_collator
in RLOOTrainer
and PPOTrainer
#2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks @bartoszzuk perhaps it's better to set the |
kashif
reviewed
Nov 18, 2024
kashif
reviewed
Nov 18, 2024
you might need to run |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
bartoszzuk
changed the title
Use specified data_collator in RLOOTrainer
Use specified data_collator in RLOOTrainer and PPOTrainer
Nov 18, 2024
kashif
approved these changes
Nov 18, 2024
qgallouedec
approved these changes
Nov 18, 2024
qgallouedec
changed the title
Use specified data_collator in RLOOTrainer and PPOTrainer
🗃️ Use specified Nov 18, 2024
data_collator
in RLOOTrainer
and PPOTrainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
data_collator
instead of using hard-codedDataCollatorWithPadding
data_collator
is specified useDataCollatorWithPadding
(previous behavior)Fixes #2354
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.