New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Use specified data_collator instead of hard-coding the option? #2354

Closed

yifeim opened this issue Nov 13, 2024 · 0 comments · Fixed by #2360

yifeim commented Nov 13, 2024

https://github.com/huggingface/trl/blob/623963126be5598bd1eea4ec82b43447fcc11535/trl/trainer/rloo_trainer.py#L202C24-L202C47

For both train_dataloader and eval_dataloader. Thanks.

bartoszzuk mentioned this issue

🗃️ Use specified data_collator in RLOOTrainer and PPOTrainer #2360

Merged

5 tasks

kashif closed this as completed in #2360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment