Skip to content

[CB] Fixes for SDPA and CPU offloading - #45733

Closed
remi-or wants to merge 3 commits into
mainfrom
cb-fix-k-race-bug
Closed

[CB] Fixes for SDPA and CPU offloading#45733
remi-or wants to merge 3 commits into
mainfrom
cb-fix-k-race-bug

Conversation

@remi-or

@remi-or remi-or commented May 1, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes two issues:

  • SDPA attn used the wrong total_seqlen_k which led to crashes
  • CPU offloading did not copy the cache correctly when blocks were non-contiguous (fancy indexing)
    This PR fixes both issues.

@remi-or
remi-or requested review from ArthurZucker and ydshieh May 1, 2026 03:59
@remi-or remi-or self-assigned this May 1, 2026
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@remi-or

remi-or commented May 7, 2026

Copy link
Copy Markdown
Collaborator Author

Closing as this was resolved in #45654

@remi-or remi-or closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants