[CB] Refactor any model-related code in a separate class#45654
Merged
Conversation
remi-or
force-pushed
the
cb-model-runner
branch
from
April 28, 2026 02:38
5965c5e to
ba4422f
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
May 4, 2026
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
yeah 300 loc is quite a lot, sounds good!
remi-or
marked this pull request as ready for review
May 4, 2026 09:53
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 4, 2026
Exile333
pushed a commit
to Exile333/transformers
that referenced
this pull request
May 6, 2026
…#45654) * Squashed model runner commits * Rebase fixes * Overhaul init * Style * Fix bugs * Fixes and simplicfications * Style * Fixes for failing tests * nit * Remove useless test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the continuous batching code by refactoring away any model-related code in the
ModelRunnerclass. This is because theContinuousBatchingProcessorclass is starting to get too big and this will help keep things organized.Draft until #45653 is merged.
Performance
Perf is on par with main, which is to be expected.
Tests
All good