-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Push CI images from Scheduled CI #19170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great solution! Makes sense, lg2m
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Let's document that somewhere :)
Added in Text versionThe CI for a push event (to main branch) will check if setup.py is changed. If yes, it will launch the docker image build CI before launching the actual tests. This is to make sure the tests will run against the specified package versions in setup.py. In order to avoid the conflict with the daily schedule CI, which should use the same image version for all jobs during a workflow run, we separate the CI images used for push events and schedule CI. The docker images used for push events start with the tag of the images used in the corresponding jobs in scheduled CI, but with a postfix push-ci. For example, transformers-all-latest-gpu in schedule CI will be transformers-all-latest-gpu-push-ci in push CI. |
2dcc751
to
66ce2af
Compare
What does this PR do?
Currently, if
setup.py
is changed, Push CI will re-build the CI images before running tests.transformers/.github/workflows/self-push-caller.yml
Lines 39 to 43 in 7e84723
However, this may cause different jobs in a scheduled CI workflow run to use images with different versions.
Recently, when
tokenizers
is changed to0.13
, some jobs failed in the scheduled CI due to the new image (withtokenizers 0.13
) but thetransformers
code in those runs still requiredtokenizers < 0.13
.This PR separates the push CI images from scheduled CI.