Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Push CI images also in a daily basis #19532

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Oct 12, 2022

What does this PR do?

PR #19170 separated the images for push CI and daily CI. However, it only build the push CI images (that with the postfix -push-ci) when changes in setup.py are detected.

We should also re-build the push CI images in a daily basis, as 3rd party libraries might have newer versions, like datasets, tokenizers etc.

@ydshieh ydshieh requested a review from sgugger October 12, 2022 15:43
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 12, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ydshieh ydshieh merged commit 5418e3c into main Oct 13, 2022
@ydshieh ydshieh deleted the fix_push_ci_image_build branch October 13, 2022 05:31
@ydshieh ydshieh mentioned this pull request Oct 19, 2022
kashif pushed a commit to kashif/transformers that referenced this pull request Oct 21, 2022
* Build Push CI images also in a daily basis

* update

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants