feat: validate template variables before apply and improve sliding wi… #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
approved these changes
Aug 12, 2024
Comment on lines
+74
to
+76
| if self.variables.contains("guideline") && guideline.is_none() { | ||
| return Err(InferError::MissingTemplateVariable("guideline".to_string())); | ||
| } |
There was a problem hiding this comment.
I wonder if there's a way to make it generic somehow ?
There was a problem hiding this comment.
yea I was thinking of a generic solution, but I think those changes would also require an update to the apply signature (to be more generic) so maybe those can be improved together in the future (as more variables are needed)
yuanwu2017
pushed a commit
to yuanwu2017/tgi-gaudi
that referenced
this pull request
Sep 26, 2024
huggingface#2403) * feat: validate template variables before apply and improve sliding window check * fix: improve missing template var test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the template to throw a better error the
guidelineis included in a template, but not provided in the request