Remove guideline from API #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
guidelineparameter from the API. This parameter was needed only for ShieldGemma models. In the end, the chat template of these models have been updated so they don't need this variable anymore. See slack thread for more context (internal).Note that I made sure the project still builds correctly + updated openapi.json from the CLI but I did not ensure any backward compatibility. Please let me know how to proceed if we want to keep a deprecated argument. To be honest, my main concern is to remove
guidelinefrom the openapi.json so that TGI api stays on-par with the specs (and the inference clients).Related PRs:
cc @Rocketknight1 @drbh @Narsil