-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add multi-backend tests for bnb #1667
Merged
+137
−2
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
# Builds GPU docker image of PyTorch | ||
# Uses multi-staged approach to reduce size | ||
# Stage 1 | ||
# Use base conda image to reduce time | ||
FROM continuumio/miniconda3:latest AS compile-image | ||
# Specify py version | ||
ENV PYTHON_VERSION=3.8 | ||
# Install apt libs - copied from https://github.com/huggingface/accelerate/blob/main/docker/accelerate-gpu/Dockerfile | ||
RUN apt-get update && \ | ||
apt-get install -y curl git wget software-properties-common git-lfs && \ | ||
apt-get clean && \ | ||
rm -rf /var/lib/apt/lists* | ||
|
||
# Install audio-related libraries | ||
RUN apt-get update && \ | ||
apt install -y ffmpeg | ||
|
||
RUN apt install -y libsndfile1-dev | ||
RUN git lfs install | ||
|
||
# Create our conda env - copied from https://github.com/huggingface/accelerate/blob/main/docker/accelerate-gpu/Dockerfile | ||
RUN conda create --name peft python=${PYTHON_VERSION} ipython jupyter pip | ||
RUN python3 -m pip install --no-cache-dir --upgrade pip | ||
|
||
# Below is copied from https://github.com/huggingface/accelerate/blob/main/docker/accelerate-gpu/Dockerfile | ||
# We don't install pytorch here yet since CUDA isn't available | ||
# instead we use the direct torch wheel | ||
ENV PATH /opt/conda/envs/peft/bin:$PATH | ||
# Activate our bash shell | ||
RUN chsh -s /bin/bash | ||
SHELL ["/bin/bash", "-c"] | ||
|
||
# Stage 2 | ||
FROM nvidia/cuda:12.1.0-devel-ubuntu22.04 AS build-image | ||
COPY --from=compile-image /opt/conda /opt/conda | ||
ENV PATH /opt/conda/bin:$PATH | ||
|
||
RUN chsh -s /bin/bash | ||
SHELL ["/bin/bash", "-c"] | ||
|
||
# Install apt libs | ||
RUN apt-get update && \ | ||
apt-get install -y curl git wget cmake && \ | ||
apt-get clean && \ | ||
rm -rf /var/lib/apt/lists* | ||
|
||
# Activate the conda env and install transformers + accelerate from source | ||
# Also clone BNB and build it from source. | ||
RUN source activate peft && \ | ||
python3 -m pip install -U --no-cache-dir \ | ||
librosa \ | ||
"soundfile>=0.12.1" \ | ||
scipy \ | ||
git+https://github.com/huggingface/transformers \ | ||
git+https://github.com/huggingface/accelerate \ | ||
peft[test]@git+https://github.com/huggingface/peft \ | ||
optimum \ | ||
auto-gptq && \ | ||
git clone https://github.com/TimDettmers/bitsandbytes && cd bitsandbytes && git checkout multi-backend-refactor && \ | ||
cmake -B . -DCOMPUTE_BACKEND=cuda -S . && \ | ||
cmake --build . && \ | ||
pip install -e . && \ | ||
pip freeze | grep bitsandbytes | ||
|
||
RUN echo "source activate peft" >> ~/.profile | ||
|
||
# Activate the virtualenv | ||
CMD ["/bin/bash"] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is a copy of: https://github.com/huggingface/peft/blob/main/docker/peft-gpu-bnb-source/Dockerfile except for this line where we checkout to multi-backend-refactor branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be added as a comment? Or perhaps, we should even add a README.md to
peft/docker/
that mentions something like: When making changes to x/Dockerfile, also change y/Dockerfile.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes totally sense ! Done !