-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add multi-backend tests for bnb #1667
Conversation
peft[test]@git+https://github.com/huggingface/peft \ | ||
optimum \ | ||
auto-gptq && \ | ||
git clone https://github.com/TimDettmers/bitsandbytes && cd bitsandbytes && git checkout multi-backend-refactor && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is a copy of: https://github.com/huggingface/peft/blob/main/docker/peft-gpu-bnb-source/Dockerfile except for this line where we checkout to multi-backend-refactor branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be added as a comment? Or perhaps, we should even add a README.md to peft/docker/
that mentions something like: When making changes to x/Dockerfile, also change y/Dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes totally sense ! Done !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @younesbelkada, LGTM, good to merge once the CI is green!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. I added a small comment, but no docker blocker.
peft[test]@git+https://github.com/huggingface/peft \ | ||
optimum \ | ||
auto-gptq && \ | ||
git clone https://github.com/TimDettmers/bitsandbytes && cd bitsandbytes && git checkout multi-backend-refactor && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be added as a comment? Or perhaps, we should even add a README.md to peft/docker/
that mentions something like: When making changes to x/Dockerfile, also change y/Dockerfile.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
bitsandbytes has now a new branch
multi-backend-refactor
: https://github.com/TimDettmers/bitsandbytes/tree/multi-backend-refactor to conduct experiments and push forward the efforts for cross-platform support for bnbThis PR extends the current existing testing suite to make sure we also conduct the same tests on bitsandbytes compiled on that branch
cc @Titus-von-Koeller @pacman100 @BenjaminBossan