Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add multi-backend tests for bnb #1667

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

younesbelkada
Copy link
Contributor

bitsandbytes has now a new branch multi-backend-refactor: https://github.com/TimDettmers/bitsandbytes/tree/multi-backend-refactor to conduct experiments and push forward the efforts for cross-platform support for bnb

This PR extends the current existing testing suite to make sure we also conduct the same tests on bitsandbytes compiled on that branch

cc @Titus-von-Koeller @pacman100 @BenjaminBossan

peft[test]@git+https://github.com/huggingface/peft \
optimum \
auto-gptq && \
git clone https://github.com/TimDettmers/bitsandbytes && cd bitsandbytes && git checkout multi-backend-refactor && \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is a copy of: https://github.com/huggingface/peft/blob/main/docker/peft-gpu-bnb-source/Dockerfile except for this line where we checkout to multi-backend-refactor branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be added as a comment? Or perhaps, we should even add a README.md to peft/docker/ that mentions something like: When making changes to x/Dockerfile, also change y/Dockerfile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes totally sense ! Done !

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @younesbelkada, LGTM, good to merge once the CI is green!

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. I added a small comment, but no docker blocker.

peft[test]@git+https://github.com/huggingface/peft \
optimum \
auto-gptq && \
git clone https://github.com/TimDettmers/bitsandbytes && cd bitsandbytes && git checkout multi-backend-refactor && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be added as a comment? Or perhaps, we should even add a README.md to peft/docker/ that mentions something like: When making changes to x/Dockerfile, also change y/Dockerfile.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada merged commit 8351814 into main Apr 25, 2024
3 of 17 checks passed
@younesbelkada younesbelkada deleted the add-bnb-multi-backend branch April 25, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants