[Internal] Fix ty quality
#3441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
commented
Oct 14, 2025
| possibly-unbound-attribute = "ignore" | ||
| unsupported-operator = "ignore" | ||
| possibly-missing-attribute = "ignore" | ||
| possibly-missing-implicit-call = "ignore" |
Contributor
Author
There was a problem hiding this comment.
i think it's safe to ignore https://docs.astral.sh/ty/reference/rules/#possibly-missing-attribute and https://docs.astral.sh/ty/reference/rules/#possibly-missing-implicit-call they are static analysis warnings that flag potential AttributeErrors if a class or object does not always define a given attribute or method.
they're safe to ignore because the code always defines those attributes or methods when it actually runs, the warning just comes from static analysis not realizing that
Co-authored-by: Lucain <lucain@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves quality check failures caused by breaking changes introduced in https://github.com/astral-sh/ty/releases/tag/0.0.1-alpha.22