[Internal] Fix ty quality (#3441)

* fix ty quality

* ignore possibly-missing-attribute

* fix

* imports

* fix

* type discussion event common args

* Update src/huggingface_hub/_webhooks_server.py

Co-authored-by: Lucain <lucain@huggingface.co>

---------

Co-authored-by: Lucain Pouget <lucainp@gmail.com>
Co-authored-by: Lucain <lucain@huggingface.co>

Author: hanouticelina

pyproject.toml

@@ -14,8 +14,9 @@ unresolved-attribute = "ignore"
 
 # Be tolerant with framework/typing edge-cases and runtime-validated code paths
 unsupported-base = "ignore"
-possibly-unbound-attribute = "ignore"
 unsupported-operator = "ignore"
+possibly-missing-attribute = "ignore"
+possibly-missing-implicit-call = "ignore"
 non-subscriptable = "ignore"
 call-non-callable = "ignore"
 

src/huggingface_hub/_webhooks_server.py

@@ -32,7 +32,7 @@
     from fastapi.responses import JSONResponse
 else:
     # Will fail at runtime if FastAPI is not available
-    FastAPI = Request = JSONResponse = None  # type: ignore [misc, assignment]
+    FastAPI = Request = JSONResponse = None  # type: ignore
 
 
 _global_app: Optional["WebhooksServer"] = None

src/huggingface_hub/community.py

@@ -7,7 +7,7 @@
 
 from dataclasses import dataclass
 from datetime import datetime
-from typing import List, Literal, Optional, Union
+from typing import List, Literal, Optional, TypedDict, Union
 
 from . import constants
 from .utils import parse_datetime
@@ -143,6 +143,14 @@ class DiscussionWithDetails(Discussion):
     diff: Optional[str]
 
 
+class DiscussionEventArgs(TypedDict):
+    id: str
+    type: str
+    created_at: datetime
+    author: str
+    _event: dict
+
+
 @dataclass
 class DiscussionEvent:
     """
@@ -319,13 +327,13 @@ def deserialize_event(event: dict) -> DiscussionEvent:
     event_type: str = event["type"]
     created_at = parse_datetime(event["createdAt"])
 
-    common_args = dict(
-        id=event_id,
-        type=event_type,
-        created_at=created_at,
-        author=event.get("author", {}).get("name", "deleted"),
-        _event=event,
-    )
+    common_args: DiscussionEventArgs = {
+        "id": event_id,
+        "type": event_type,
+        "created_at": created_at,
+        "author": event.get("author", {}).get("name", "deleted"),
+        "_event": event,
+    }
 
     if event_type == "comment":
         return DiscussionComment(

src/huggingface_hub/serialization/_torch.py

@@ -266,7 +266,7 @@ def save_torch_state_dict(
     safe_file_kwargs = {"metadata": per_file_metadata} if safe_serialization else {}
     for filename, tensors in state_dict_split.filename_to_tensors.items():
         shard = {tensor: state_dict[tensor] for tensor in tensors}
-        save_file_fn(shard, os.path.join(save_directory, filename), **safe_file_kwargs)
+        save_file_fn(shard, os.path.join(save_directory, filename), **safe_file_kwargs)  # ty: ignore[invalid-argument-type]
         logger.debug(f"Shard saved to {filename}")
 
     # Save the index (if any)