Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tabular regression task and renamed Structured Data Classification widget #166

Closed
wants to merge 6 commits into from
Closed

Conversation

merveenoyan
Copy link
Contributor

This PR adds tabular-regression task, it's icon and renames the widget and uses it for both tabular-classification and tabular-regression tasks (swapped StructuredDataClassificationWidget with TabularDataWidget)

@merveenoyan
Copy link
Contributor Author

image
Haven't built moon-landing since forever and now trying to build it locally to see how it looks like and don't have access to gitaly ✨

@osanseviero
Copy link
Contributor

You don't need Gitaly, you can just do NODE_REPOS=0 npm run watch and follow the process at https://github.com/huggingface/moon-landing#annex-quickndirty-way-to-run-blog-on-your-local-machine. You can either use docker or just use redis/mongo if you want something quick.

@merveenoyan
Copy link
Contributor Author

@osanseviero I did start mongo and redis and I got errors regarding gitaly. I'm currently removing everything and start from scratch, it usually works when I do that :)

@osanseviero
Copy link
Contributor

Partly fixes #137

@osanseviero
Copy link
Contributor

There seems to be a merge conflict. Could you also add a screenshot of how the icon looks at the description of the PR please?

@merveenoyan
Copy link
Contributor Author

Ekran Resmi 2022-06-01 18 24 53 (1)

I fixed the Task name at the "Adding a Task" page that's why there's a merge conflict.

@osanseviero
Copy link
Contributor

Yeah, you need to merge to fix the conflict if not it can't be merged 😄

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@merveenoyan
Copy link
Contributor Author

IDK why but my conflict was very small yet it said it was too big, didn't raise it as a conflict. 🤯 it's fine as is.

@merveenoyan merveenoyan requested a review from osanseviero June 2, 2022 13:54
@merveenoyan
Copy link
Contributor Author

Closing because it was easier to actually open another PR from a branch of a main repo (in favor of this #176) I made my life harder 😅

@merveenoyan merveenoyan closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants