Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tabular regression and renamed structured data #176

Merged
merged 7 commits into from
Jun 3, 2022
Merged

Conversation

merveenoyan
Copy link
Contributor

This PR adds tabular-regression task, it's icon and renames the widget and uses it for both tabular-classification and tabular-regression tasks (swapped StructuredDataClassificationWidget with TabularDataWidget)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 2, 2022

The documentation is not available anymore as the PR was closed or merged.

@merveenoyan merveenoyan requested a review from osanseviero June 2, 2022 16:41
@merveenoyan
Copy link
Contributor Author

Ekran Resmi 2022-06-02 17 55 52

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left two nits and one question for @lhoestq

js/src/lib/interfaces/Types.ts Outdated Show resolved Hide resolved
@@ -466,9 +466,14 @@ export const PIPELINE_DATA = ensureRecordOfPipelines({
],
color: "blue",
},
"tabular-regression": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhoestq do we want to hide this in datasets or is it good?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, thanks !

js/src/lib/interfaces/Types.ts Outdated Show resolved Hide resolved
merveenoyan and others added 2 commits June 3, 2022 14:35
@osanseviero
Copy link
Contributor

Btw when opening PRs related to an issue, please mention them so they are linked.

Partially fixes #137

@merveenoyan merveenoyan requested a review from osanseviero June 3, 2022 14:09
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the change 🔥

{
type: "tabular-single-column-regression",
name: "Tabular Single Column Classification",
name: "Tabular Single Column Regression",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@merveenoyan merveenoyan merged commit 341685a into main Jun 3, 2022
@merveenoyan merveenoyan deleted the add_tabular branch June 3, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants