-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tabular regression and renamed structured data #176
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left two nits and one question for @lhoestq
@@ -466,9 +466,14 @@ export const PIPELINE_DATA = ensureRecordOfPipelines({ | |||
], | |||
color: "blue", | |||
}, | |||
"tabular-regression": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lhoestq do we want to hide this in datasets or is it good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine, thanks !
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
Btw when opening PRs related to an issue, please mention them so they are linked. Partially fixes #137 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the change 🔥
{ | ||
type: "tabular-single-column-regression", | ||
name: "Tabular Single Column Classification", | ||
name: "Tabular Single Column Regression", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
This PR adds tabular-regression task, it's icon and renames the widget and uses it for both tabular-classification and tabular-regression tasks (swapped StructuredDataClassificationWidget with TabularDataWidget)