Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Austenem/CAT-790 Remove last modified sections #3607

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

austenem
Copy link
Collaborator

Summary

Switch to showing Creation Date for samples/donors (previously Last Modified) and switch to showing Publication DateLast Modified for datasets (previously Publication DateCreation Date).

This update affects detail pages and the home page but no search pages.

Design Documentation/Original Tickets

CAT-790 Jira ticket

Testing

Checked examples of the affected pages - see screenshots below. Also checked Workspaces pages, which are the only remaining pages with tables that have a Last Modified column.

Screenshots/Video

Processed Dataset Summary

Screenshot 2024-11-15 at 10 20 33 AM

(a ticket has been made for the entity header styling issue)

Sample Detail Page

Screenshot 2024-11-15 at 10 02 29 AM

Donor Detail Page

Screenshot 2024-11-15 at 9 54 17 AM

Screenshot 2024-11-15 at 9 54 07 AM

Dataset Provenance

Screenshot 2024-11-15 at 9 51 38 AM

Home Page 'Recent Datasets'

Now showing most recently published datasets rather than most recently modified.
Screenshot 2024-11-15 at 9 50 23 AM

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Other Notes

The getEntityCreationInfo function is now being used as the single source of truth for showing creation data in order to facilitate changes to this logic later on.

Many areas not listed in the screenshots have been updated to use this function, but their actual logic has not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant