Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe single valued hierarchical parents/children #3599

Conversation

john-conroy
Copy link
Collaborator

Summary

Dedupes hierarchical facet items where the parent only has a single child which matches the parent.

Screenshots/Video

Screenshot 2024-11-05 at 4 39 17 PM

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@john-conroy john-conroy merged commit 233062b into john-conroy/reset-all-filters Nov 6, 2024
4 of 5 checks passed
@john-conroy john-conroy deleted the john-conroy/single-value-hierarchical-facets branch November 6, 2024 15:05
john-conroy added a commit that referenced this pull request Nov 6, 2024
* Add reset method to store

* Add reset filters button

* Fix styles

* Dedupe single valued hierarchical parents/children (#3599)

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>

---------

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants