Tkakar/cat 673 add epics support #3586
Conversation
context/app/utils.py
Outdated
| max_modified_date = None | ||
| max_date_descendant = None | ||
| for descendant in descendants: | ||
| dec_entity = client.get_entity(descendant) |
There was a problem hiding this comment.
We should consolidate this into a single request using get_entities.
context/app/utils.py
Outdated
| dec_entity = client.get_entity(descendant) | ||
| # TODO: Until we have better entity qualifier | ||
| if dec_entity.get('creation_action').lower() == 'central process' and len( | ||
| dec_entity.get('files')) > 0 and dec_entity.get('status').lower() != 'error': |
There was a problem hiding this comment.
Historically we've lifted entities that are in QA or Published, should we continue that logic here?
context/app/utils.py
Outdated
| mapped_last_modified_timestamp = datetime.strptime( | ||
| dec_entity.get('mapped_last_modified_timestamp'), "%Y-%m-%d %H:%M:%S") | ||
| if max_modified_date is None or mapped_last_modified_timestamp > max_modified_date: |
There was a problem hiding this comment.
I likely prompted using mapped_last_modified_timestamp in standup, but we can use last_modified_timestamp which is an int.
context/app/routes_browse.py
Outdated
| if parent is None: | ||
| ancestors = entity.get('immediate_ancestors') | ||
| if len(ancestors) > 0 and ancestors[0]['entity_type'] == 'Dataset': |
There was a problem hiding this comment.
It would be preferable to use immediate_ancestors_ids and make a request to get the ancestor entities. immediate_ancestors is somewhat deprecated as it greatly increases the ES document size. We could have the query only return datasets.
|
@john-conroy thanks for the suggestions. Will work on implementing them. |
"merged main".
| const handleWarning = useCallback( | ||
| (message: string) => { | ||
| // Suppress the "Node not found" message that appears when no zarr file was found | ||
| if (message.includes('Node not found')) { |
There was a problem hiding this comment.
I'm seeing a Unexpected response status 401 warning from what appears to be the same zarr issue, based on the network logs:
I think we could add that as another message to match against.
Summary
This PR adds support to visualize EPIC segmentation masks in the unified views.
Design Documentation/Original Tickets
CAT-673
Testing
Manually tested for test datasets on Dev with visualizations
Screenshots/Video
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.Additional Notes
Please specify any additional information or context relevant to this PR.