Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Austenem/CAT-962 Show panel title on hover #3579

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

austenem
Copy link
Collaborator

Summary

If a title or description in a processed dataset helper panel is truncated, show the full text on hover in a tooltip.

Design Documentation/Original Tickets

CAT-962 Jira ticket

Testing

Tested by checking both truncated and non-truncated panel text examples.

Screenshots/Video

Screenshot 2024-10-23 at 10 36 11 AM Screenshot 2024-10-23 at 10 35 25 AM

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

john-conroy
john-conroy previously approved these changes Oct 23, 2024
Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@john-conroy
Copy link
Collaborator

Should we add this for other instances of LineClamp. Perhaps for the summary/entity header components?

@austenem
Copy link
Collaborator Author

Should we add this for other instances of LineClamp. Perhaps for the summary/entity header components?

I think that's a good idea! Added for the summary/entity header on the detail page. The other instances of LineClamp are in tables of results, which might make the tooltips more annoying than helpful - additionally, in these instances the full text could be viewed by clicking on the result. I'm open to other opinions on that, though.

@austenem austenem merged commit 178bcd7 into main Oct 23, 2024
8 checks passed
@austenem austenem deleted the austenem/cat-962-show-panel-title-on-hover branch October 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants