Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kevin yoo/hmp 305 implement tooltips for swedlow feedback response #3196

Conversation

kevinyooky
Copy link
Contributor

No description provided.

@kevinyooky kevinyooky marked this pull request as ready for review July 25, 2023 16:01
@kevinyooky
Copy link
Contributor Author

Datasets (below)

image
image

Samples (below)

image
image

Donors (below)

image

@kevinyooky
Copy link
Contributor Author

I found some weird side effect here, so going to look this one more

image

Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much improved! This PR was much easier to review and understand. A few very minor changes to address.

@kevinyooky
Copy link
Contributor Author

I ran the main branch and still see this issue, so this appears to be unrelated to the changes that I made.

image

@kevinyooky kevinyooky requested a review from lchoy July 25, 2023 19:37
lchoy
lchoy previously approved these changes Jul 25, 2023
john-conroy
john-conroy previously approved these changes Jul 25, 2023
Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A couple last comments you can take or leave.

@kevinyooky kevinyooky dismissed stale reviews from john-conroy and lchoy via 418cee8 July 25, 2023 22:05
Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kevinyooky kevinyooky merged commit d1b9ff7 into main Jul 26, 2023
8 checks passed
@kevinyooky kevinyooky deleted the kevin-yoo/HMP-305-Implement-tooltips-for-Swedlow-feedback-response branch July 26, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants