-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kevin yoo/hmp 305 implement tooltips for swedlow feedback response #3196
Kevin yoo/hmp 305 implement tooltips for swedlow feedback response #3196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much improved! This PR was much easier to review and understand. A few very minor changes to address.
context/app/static/js/components/detailPage/Attribution/Attribution.jsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/BulkDataTransfer/BulkDataTransfer.jsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/CollectionsSection/CollectionsSection.jsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/MetadataTable/MetadataTable.jsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/Protocol/Protocol.jsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/provenance/ProvSection/ProvSection.jsx
Outdated
Show resolved
Hide resolved
...ts/detailPage/related-entities/RelatedEntitiesSectionHeader/RelatedEntitiesSectionHeader.jsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/Protocol/Protocol.jsx
Outdated
Show resolved
Hide resolved
CHANGELOG-HMP-305-Implement-tooltips-for-Swedlow-feedback-response.md
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/BulkDataTransfer/BulkDataTransfer.jsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/CollectionsSection/CollectionsSection.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A couple last comments you can take or leave.
...ts/detailPage/related-entities/RelatedEntitiesSectionHeader/RelatedEntitiesSectionHeader.jsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
No description provided.