-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to import Mapping and MutableMapping from collections.abc #403
Conversation
Note that collections.abc has been added in Python 3.3. Fixes html5lib#402
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 90.76% 90.77% +<.01%
==========================================
Files 50 50
Lines 6950 6956 +6
Branches 1328 1328
==========================================
+ Hits 6308 6314 +6
Misses 483 483
Partials 159 159
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Would be great to have a release shipping this among the other improvements! |
Still no release with this patch after a year? 😢 |
Edit: apologies for the noise, there's already discussion happening about this in #419. This is now breaking with Python 3.9:
|
Note that collections.abc has been added in Python 3.3.
Fixes #402