Fix collections imports for Python 3.8 #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated
|
Could you make an release? |
|
Hey @gsnedders, as Python 3.8 is released, I guess it would be generally very much appreciated if you could release a version on PyPI which includes this fix. Thank you very much! |
|
There is no fix here, this pull request makes no sense and was retracted by its author in response to this comment: #405 (comment) The actually relevant discussion was at #402 and #403, and #419 is already submitted asking for a new release. |
|
I already noticed, but thanks for pointing it out. I forgot to delete my useless comment. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated
Fixes #405