clarify documentation around stringMatch and case-sensitivity (istio#…

…3304) Signed-off-by: Ian Rudie <ian.rudie@solo.io>
howardjohn · Sep 5, 2024 · 18c9295 · 18c9295
1 parent 0a8281c
commit 18c9295
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 10 deletions.
diff --git a/networking/v1/virtual_service_alias.gen.go b/networking/v1/virtual_service_alias.gen.go
diff --git a/networking/v1alpha3/virtual_service.pb.go b/networking/v1alpha3/virtual_service.pb.go
diff --git a/networking/v1alpha3/virtual_service.pb.html b/networking/v1alpha3/virtual_service.pb.html
diff --git a/networking/v1alpha3/virtual_service.proto b/networking/v1alpha3/virtual_service.proto
@@ -1240,8 +1240,8 @@ message RegexRewrite {
   string rewrite = 2;
 }
 
-// Describes how to match a given string in HTTP headers. Match is
-// case-sensitive.
+// Describes how to match a given string in HTTP headers. `exact` and `prefix` matching is
+// case-sensitive. `regex` matching supports case-insensitive matches.
 message StringMatch {
   oneof match_type {
 
@@ -1252,6 +1252,8 @@ message StringMatch {
     string prefix = 2;
 
     // [RE2 style regex-based match](https://github.com/google/re2/wiki/Syntax).
+    //
+    // Example: `(?i)^aaa$` can be used to case-insensitive match a string consisting of three a's.
     string regex = 3;
   }
 }

diff --git a/networking/v1beta1/virtual_service_alias.gen.go b/networking/v1beta1/virtual_service_alias.gen.go