Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify documentation around stringMatch and case-sensitivity #3304

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

ilrudie
Copy link
Contributor

@ilrudie ilrudie commented Sep 5, 2024

seeks to add clarification around case-sensitive vs case-insensitive options for stringMatch in the VirtualService API

Signed-off-by: Ian Rudie <ian.rudie@solo.io>
@ilrudie ilrudie requested a review from a team as a code owner September 5, 2024 18:45
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2024
Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ian!!

@ilrudie ilrudie added the release-notes-none Indicates a PR that does not require release notes. label Sep 5, 2024
@ilrudie
Copy link
Contributor Author

ilrudie commented Sep 5, 2024

/retest

@ilrudie ilrudie added the cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch label Sep 5, 2024
@ilrudie
Copy link
Contributor Author

ilrudie commented Sep 5, 2024

1.22 has the same verbiage, we could consider cherry-picking the doc update for it as well

@istio-testing istio-testing merged commit 18c9295 into istio:master Sep 5, 2024
5 checks passed
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #3305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.23 Set this label on a PR to auto-merge it to the release-1.23 branch release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants