Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: Blank header appears on return detail page if ShopifyOrderName and HC OrderID are not present (#399) #405

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fixed: Blank header appears on return detail page if ShopifyOrderName and HC OrderID are not present (#399) #405

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1cf42a
fixed: #399 Blank header appears on return detail page if ShopifyOrde…
ashutosh7i Oct 19, 2024
047fce5
fix: updated static Return text to internationalized text
ashutosh7i Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/views/ReturnDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<main>
<div class="doc-id">
<ion-item lines="none">
<h1>{{ current.shopifyOrderName ? current.shopifyOrderName : current.hcOrderId }}</h1>
<h1> {{ current.shopifyOrderName ? current.shopifyOrderName : current.hcOrderId ? current.hcOrderId : current.externalId ? current.externalId : 'Return' }}</h1>
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 Oct 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make the static text internationalize like the one done for Return Details text in title.

Also can you make the static text same as the one displayed in title Return Details

<!-- TODO: Fetch Customer name -->
<!-- <p>{{ translate("Customer: <customer name>")}}</p> -->
</ion-item>
Expand Down
Loading