fixed: Blank header appears on return detail page if ShopifyOrderName and HC OrderID are not present (#399) #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fyOrderName and HC OrderID are not present
ymaheshwari1
requested changes
Oct 19, 2024
There was a problem hiding this comment.
Thanks for the contribution @ashutosh7i .
Please check the comment below, once done this PR will be good to be merged.
src/views/ReturnDetails.vue
Outdated
| @@ -11,7 +11,7 @@ | |||
| <main> | |||
| <div class="doc-id"> | |||
| <ion-item lines="none"> | |||
| <h1>{{ current.shopifyOrderName ? current.shopifyOrderName : current.hcOrderId }}</h1> | |||
| <h1> {{ current.shopifyOrderName ? current.shopifyOrderName : current.hcOrderId ? current.hcOrderId : current.externalId ? current.externalId : 'Return' }}</h1> | |||
There was a problem hiding this comment.
We need to make the static text internationalize like the one done for Return Details text in title.
Also can you make the static text same as the one displayed in title Return Details
|
Thank you, op.mp4 |
ymaheshwari1
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#399
Short Description and Why It's Useful
When ShopifyOrderName and HC OrderID are missing, the header now displays alternative identifiers External ID. If no such identifiers is available, a placeholder message "Return" is shown ensuring the header is not blank.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance