Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Product identifiers is visible for selected product(#373) #374

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Apr 30, 2024

Related Issues

#373

Short Description and Why It's Useful

  • Using getProductIdentificationValue from dxp-component in all the components.
  • Deprecated the /Product/index.ts file as now we are using the functionality from the dxp-component.
  • Added the use of getProductIdentificationValue for getting the Product identifier.
  • It also sets the default identifier if current save identifier is missing.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2024-04-30 11-32-26

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

src/views/AddProductModal.vue Outdated Show resolved Hide resolved
@ymaheshwari1 ymaheshwari1 merged commit 29636bb into hotwax:main Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants