Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product identifiers missing in new product shipment modal. #373

Closed
Adameddy26 opened this issue Apr 29, 2024 · 2 comments
Closed

Product identifiers missing in new product shipment modal. #373

Adameddy26 opened this issue Apr 29, 2024 · 2 comments
Assignees
@Adameddy26
Labels
bug Something isn't working release-v2.27.0

Comments

@Adameddy26
Copy link

Expected behavior

Product identifiers should be clearly visible with the product image while adding a new product against any shipment.

Steps to reproduce the issue

Login the App with valid user credentials.
Go to settings page and select the product identifiers as SHOPIFY_PROD_SKU or ERP_ID or UPCA.
Navigate to shipment or PO page.
Open any shipment.
Choose to add a new shipment.
Search the product which is not part of shipment with its sku.
Observe the issue

Environment details

App version - v2.26.0
App environment - UAT

Additional information

Screenshot from 2024-04-29 17-04-41
@Adameddy26 Adameddy26 added the bug Something isn't working label Apr 29, 2024
@ymaheshwari1
Copy link
Contributor

ymaheshwari1 commented Apr 29, 2024 •
edited
Loading

Add a default identifier if the current selected identifiers are missing. Use the same default identifier as displayed on details page.
Also check this in all the other add product modals.

R-Sourabh added a commit to R-Sourabh/receiving that referenced this issue Apr 30, 2024
@R-Sourabh
Fixed: Product identifiers is visible for selected product(hotwax#373)
a4ae986
@R-Sourabh R-Sourabh mentioned this issue Apr 30, 2024
Merged
1 task
R-Sourabh added a commit to R-Sourabh/receiving that referenced this issue Apr 30, 2024
@R-Sourabh
Improved: using function from dxp-component & add productName check(h…
38a8100 
…otwax#373)
ymaheshwari1 added a commit that referenced this issue Apr 30, 2024
@ymaheshwari1
Merge pull request #374 from R-Sourabh/#373-product-identifier
29636bb 
Fixed: Product identifiers is visible for selected product(#373)
@R-Sourabh R-Sourabh removed their assignment Jul 15, 2024
@Adameddy26 Adameddy26 self-assigned this Sep 27, 2024
@Adameddy26
Copy link
Author

Verified and working fine in release v2.27.0. Hence, closing it.
https://jam.dev/c/15bef56a-1022-423d-accc-d438ed4ff896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v2.27.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ymaheshwari1 @R-Sourabh @Adameddy26