Merge pull request #478 from R-Sourabh/#471-filter-open-issue

Fixed: multiple menu opening issue by giving unique id to each menu (#471)
hotwax · Oct 15, 2024 · 3d05506 · 3d05506
2 parents 1d10f10 + 7221de5
commit 3d05506
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/views/Assigned.vue b/src/views/Assigned.vue
@@ -1,11 +1,11 @@
 <template>
   <ion-page>
-    <Filters menu-id="filter" content-id="filter"/>
+    <Filters menu-id="assigned-filter" content-id="filter"/>
     <ion-header>
       <ion-toolbar>
         <ion-title>{{ translate("Assigned")}}</ion-title>
         <ion-buttons slot="end">
-          <ion-menu-button menu="filter">
+          <ion-menu-button menu="assigned-filter">
             <ion-icon :icon="filterOutline" />
           </ion-menu-button>
         </ion-buttons>

diff --git a/src/views/Closed.vue b/src/views/Closed.vue
@@ -1,12 +1,12 @@
 <template>
   <ion-page>  
-    <Filters menu-id="filter" content-id="filter"/>
+    <Filters menu-id="closed-filter" content-id="filter"/>
     <ion-header>
       <ion-toolbar>
         <ion-menu-button slot="start" menu="start"/>
         <ion-title>{{ translate("Closed")}}</ion-title>
         <ion-buttons slot="end">
-          <ion-menu-button menu="filter">
+          <ion-menu-button menu="closed-filter">
             <ion-icon :icon="filterOutline"/>
           </ion-menu-button>
         </ion-buttons>

diff --git a/src/views/Draft.vue b/src/views/Draft.vue
@@ -1,6 +1,6 @@
 <template>
   <ion-page>
-    <Filters menu-id="draft-filter" content-id="draft-filter"/>
+    <Filters menu-id="draft-filter" content-id="filter"/>
     <ion-header>
       <ion-toolbar>
         <ion-menu-button slot="start" menu="start"/>
@@ -13,7 +13,7 @@
       </ion-toolbar>
     </ion-header>
 
-    <ion-content id="draft-filter">
+    <ion-content id="filter">
       <p v-if="!cycleCounts.length" class="empty-state">
         {{ translate("No cycle counts found") }}
       </p>

diff --git a/src/views/PendingReview.vue b/src/views/PendingReview.vue
@@ -1,11 +1,11 @@
 <template>
   <ion-page>
-    <Filters menu-id="filter" content-id="filter"/>
+    <Filters menu-id="pending-review-filter" content-id="filter"/>
     <ion-header>
       <ion-toolbar>
         <ion-title>{{ translate("Pending review")}}</ion-title>
         <ion-buttons slot="end">
-          <ion-menu-button menu="filter">
+          <ion-menu-button menu="pending-review-filter">
             <ion-icon :icon="filterOutline" />
           </ion-menu-button>
         </ion-buttons>