switcher add current temperature sensor to thermostat devices #35759
Conversation
home-assistant
bot
added
in-progress
|
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
home-assistant
bot
removed
the
needs-rebase
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces a new sensor named Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SwitcherIntegration
participant CurrentTemperatureSensor
User->>SwitcherIntegration: Request sensor data
SwitcherIntegration->>CurrentTemperatureSensor: Fetch current temperature
CurrentTemperatureSensor-->>SwitcherIntegration: Return temperature data
SwitcherIntegration-->>User: Provide temperature data
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
source/_integrations/switcher_kis.markdown (2)
103-106: LGTM! Consider adding more sensor details.The documentation for the new temperature sensor follows the established format and provides clear information. Consider enhancing it with:
- Information about unit conversion (if Fahrenheit is supported)
- Temperature precision and range details
For Switcher Breeze the integration provides the following sensor: | Sensor Name | Description | Example | | --------------------- | ------------------------------------------------------ | ----------------- | -| `Current Temperature` | The current temperature in celsius | 25.0 °C | +| `Current Temperature` | The current temperature (supports Celsius/Fahrenheit) | 25.0 °C | +| | Range: 16-32°C, Precision: 0.1°C | |🧰 Tools
🪛 Markdownlint
104-104: null
Tables should be surrounded by blank lines(MD058, blanks-around-tables)
103-107: Add blank lines around the table.To improve readability and follow markdown best practices, add blank lines before and after the table.
For Switcher Breeze the integration provides the following sensor: + | Sensor Name | Description | Example | | --------------------- | ------------------------------------------------------ | ----------------- | | `Current Temperature` | The current temperature in celsius | 25.0 °C | +🧰 Tools
🪛 Markdownlint
104-104: null
Tables should be surrounded by blank lines(MD058, blanks-around-tables)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/switcher_kis.markdown(1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/switcher_kis.markdown
104-104: null
Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
source/_integrations/switcher_kis.markdown (2)
102-107: Add blank lines around the table for better readabilityAccording to markdown best practices, tables should be surrounded by blank lines. Please add blank lines before and after the table.
Apply this formatting:
*Currently not supported for Switcher Power Plug For Switcher Breeze the integration provides the following sensor: + | Sensor Name | Description | Example | | --------------------- | ------------------------------------------------------ | ----------------- | | `Current temperature` | The current temperature in celsius | 25.0 °C | +🧰 Tools
🪛 Markdownlint
104-104: null
Tables should be surrounded by blank lines(MD058, blanks-around-tables)
106-106: Improve temperature sensor documentation formattingA few minor improvements to the sensor documentation:
- Add backticks around the sensor name for consistency with other sensor documentation
- Capitalize "Celsius" as it's a proper noun named after Anders Celsius
Apply this formatting:
-| Current temperature | The current temperature in celsius | 25.0 °C | +| `Current temperature` | The current temperature in Celsius | 25.0 °C |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/switcher_kis.markdown(1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/switcher_kis.markdown
104-104: null
Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
home-assistant
bot
removed
parent-merged
Proposed change
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit
New Features
Current Temperature, for the Switcher Breeze integration, enhancing sensor capabilities.Documentation