Switcher add current current temperature sensor

[YogevBokobza]

Proposed change

Adding a sensor for the current temperature of Thermostat Switcher devices

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: switcher add current temperature sensor to thermostat devices home-assistant.io#35759

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @thecode, mind taking a look at this pull request as it has been labeled with an integration (switcher_kis) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switcher_kis can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign switcher_kis Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[thecode]

Temperature is already provided by the climate entity -

core/homeassistant/components/switcher_kis/climate.py

Line 136 in 762c800

self._attr_current_temperature = data.temperature

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[YogevBokobza]

Temperature is already provided by the climate entity -

core/homeassistant/components/switcher_kis/climate.py

Line 136 in 762c800

self._attr_current_temperature = data.temperature

I think it is easier to work with a sensor entity rather than searching the entity's attributes, especially for using in automations.
I can remove this from the climate attributes if you worry about duplication.

Plus, this temperature is by no means the "device's temperature" it is shows the outside temperature.. I think it makes more sense to make it its own sensor.

[YogevBokobza]

The end results look like this:

[frenck]

Removed my accidental approval, awaiting approval from @thecode

[thecode]

To be honest I don't like creating sensors from climate entity since this opens a path for creating sensors for rare cases instead of templates, however since Home Assistant allows creating temperature sensor for the climate entity, mainly to allow long term statistics for this sensor I am approving this PR.

Please note that future sensors for the climate entity will be rejected (I already saw a request for a binary sensor if the AC is on)

Thanks

[thecode]

@YogevBokobza once again I ask, please avoid constantly force pushing a branch for no reason, this has already pass tests, so no need to force push the branch

[YogevBokobza]

@YogevBokobza once again I ask, please avoid constantly force pushing a branch for no reason, this has already pass tests, so no need to force push the branch

It seems like I had to.. it was failing on something weird not related to this PR

[YogevBokobza]

@YogevBokobza once again I ask, please avoid constantly force pushing a branch for no reason, this has already pass tests, so no need to force push the branch

It seems like I had to.. it was failing on something weird not related to this PR

@thecode Failed again on this "CI / Upload test coverage to Codecov (partial suite) (pull_request)" do you know what this is and how to resolve it?