-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensor platform to eq3btsmart #35723
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request enhance the integration of eQ-3 Bluetooth Smart Thermostats within Home Assistant by adding two new platforms, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant EQ3Thermostat
User->>HomeAssistant: Configure eQ-3 Bluetooth Smart Thermostat
HomeAssistant->>EQ3Thermostat: Connect and Pair
EQ3Thermostat-->>HomeAssistant: Send status and data
HomeAssistant->>User: Display thermostat data (including number and sensor data)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- number | ||
- sensor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation needed for new platforms
While adding the number
and sensor
platforms to ha_platforms
, there's no documentation describing:
- What sensors are available
- What numbers can be controlled
- Available attributes and their units
- Configuration options if any
This information is crucial for users to understand and utilize these new platforms effectively.
Please add documentation sections for both platforms following Home Assistant's documentation standards. Here's a suggested structure:
## Number
The number platform allows you to control...
Available numbers:
- `number_name`: Description and valid ranges
## Sensor
The sensor platform provides...
Available sensors:
- `sensor_name`: Description and units
Proposed change
This PR adds the
sensor
platform to theeq3btsmart
integration.Needs #35721 to get merged first.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
number
andsensor
platforms.