-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensor platform to eq3btsmart #130438
Merged
joostlek
merged 1 commit into
home-assistant:dev
from
EuleMitKeule:feature/eq3btsmart-sensor
Nov 15, 2024
Merged
Add sensor platform to eq3btsmart #130438
joostlek
merged 1 commit into
home-assistant:dev
from
EuleMitKeule:feature/eq3btsmart-sensor
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @dbuezas, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
19 tasks
EuleMitKeule
force-pushed
the
feature/eq3btsmart-sensor
branch
from
November 14, 2024 22:00
4c0da06
to
f2fb30a
Compare
EuleMitKeule
force-pushed
the
feature/eq3btsmart-sensor
branch
from
November 15, 2024 17:28
f2fb30a
to
0804fa5
Compare
joostlek
requested changes
Nov 15, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
EuleMitKeule
force-pushed
the
feature/eq3btsmart-sensor
branch
from
November 15, 2024 17:47
0804fa5
to
a44b632
Compare
joostlek
reviewed
Nov 15, 2024
EuleMitKeule
force-pushed
the
feature/eq3btsmart-sensor
branch
from
November 15, 2024 17:51
a44b632
to
1228fbc
Compare
joostlek
approved these changes
Nov 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR adds the
sensor
platform to theeq3btsmart
integration. The new entities allow the user to observe the valve open percentage and the away until date of the thermostat.Needs #130429 to get merged first.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: